Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache fixes for e2e tests #1803

Merged
merged 3 commits into from
Feb 20, 2024
Merged

cache fixes for e2e tests #1803

merged 3 commits into from
Feb 20, 2024

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Feb 19, 2024

Why this change is needed

Some e2e tests were failing because of caching.

What changes were made as part of this PR

  • Exclude caching of: "eth_getTransactionCount" and "eth_getBalance".
  • Fix to return the correct request ID

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@zkokelj zkokelj marked this pull request as ready for review February 19, 2024 17:31
BedrockSquirrel
BedrockSquirrel approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zkokelj zkokelj merged commit 038f6a6 into main Feb 20, 2024
2 checks passed
@zkokelj zkokelj deleted the ziga/fix_tests_after_caching branch February 20, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BedrockSquirrel BedrockSquirrel BedrockSquirrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkokelj @BedrockSquirrel